Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infotip/Tooltip: issues when ancestor has overflow:hidden #1401

Closed
PrashantAshok opened this issue May 28, 2021 · 5 comments
Closed

Infotip/Tooltip: issues when ancestor has overflow:hidden #1401

PrashantAshok opened this issue May 28, 2021 · 5 comments
Assignees
@agliga
Labels
component: infotip component: tooltip priority: 3 Fix should be on roadmap or backlog status: backlog type: bug
Milestone
13.0.0

Comments

@PrashantAshok
Copy link
Contributor

Bug Report

eBayUI Version: 7.3.1

Description

This is related to #535 - But this issue could happen when the tooltip is rendered inside a parent with overflow: hidden

Workaround

None

Screenshots

Screen Shot 2021-04-29 at 12 05 55 PM
@PrashantAshok
Copy link
Contributor Author

@ianmcburnie @agliga - Thinking aloud, we should be able to solve this (and maybe #535) by rendering the tooltip__overlay or infotip__overlay inside a Marko portal

@ianmcburnie
Copy link
Contributor

@PrashantAshok If we move the overlay elsewhere in the DOM, it's going to cause issues for the reading order and keyboard order.

@PrashantAshok
Copy link
Contributor Author

PrashantAshok commented Jun 2, 2021 •
edited
Loading

Reading order - can this not be solved using live-regions? orders - good point, hmm unsure of this.

@PrashantAshok
Copy link
Contributor Author

We found a similar issue - but with ebay-menu-button - There are more options which are being hidden now.

screenshot-1

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jun 3, 2021 •
edited
Loading

Yes, for situations like this when overflow is being hidden, you will need to apply some additional CSS at the app level.

https://stackoverflow.com/questions/39146047/display-tooltip-when-container-overflow-is-hidden

@ianmcburnie ianmcburnie changed the title Infotip/Tooltip: enhance with parent overflow:hidden Infotip/Tooltip: issues when ancestor has overflow:hidden Jun 28, 2021
@ianmcburnie ianmcburnie added the priority: 3 Fix should be on roadmap or backlog label Jun 28, 2021
@Dkalyanasundaram Dkalyanasundaram mentioned this issue Sep 13, 2021
Closed
@PrashantAshok PrashantAshok mentioned this issue Dec 2, 2021
Open
@agliga agliga self-assigned this Sep 19, 2023
@agliga agliga added this to eBayUI Sep 19, 2023
@agliga agliga added this to the 13.0.0 milestone Sep 19, 2023
@agliga agliga moved this to Todo in eBayUI Sep 19, 2023
@agliga agliga moved this from Todo to In Progress in eBayUI Sep 27, 2023
@agliga agliga modified the milestones: 13.0.0, 12.7.0 Sep 27, 2023
@agliga agliga modified the milestones: 12.7.0, 13.0.0 Oct 10, 2023
@agliga agliga moved this from In Progress to Pull request in eBayUI Dec 14, 2023
@agliga agliga moved this from Pull request to Done in eBayUI Dec 22, 2023
@agliga agliga closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agliga agliga

Labels
component: infotip component: tooltip priority: 3 Fix should be on roadmap or backlog status: backlog type: bug
Projects
eBayUI
Status: No status
Milestone
13.0.0
Development

No branches or pull requests
3 participants
@ianmcburnie @agliga @PrashantAshok