Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdowns: enhance with viewport boundary detection #535

Open
hramakumar opened this issue Feb 5, 2019 · 10 comments
Open

Dropdowns: enhance with viewport boundary detection #535

hramakumar opened this issue Feb 5, 2019 · 10 comments

Comments

@hramakumar
Copy link

Bug Report

eBayUI Version: 2.0.0-2 and skin 7.0.0-5

Description

when info tip has content that goes out og page boundary. it truncates.
screenshot_20190205-092444

Workaround

Screenshots

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Feb 5, 2019

@seangates I believe we were going to add the logic for this in a future version. Is that correct? If so we can mark this as an enhancement ticket and I can remove the "blocker" label.

@hramakumar hramakumar removed the severity: blocker For "type: bug" only label Feb 5, 2019
@ianmcburnie ianmcburnie changed the title infotip: when content goes out of page boundary Infotip: when content goes out of page boundary Feb 5, 2019
@ianmcburnie ianmcburnie added the fellowship: good first issue A task that will take a day or more with minimal supervision label Feb 16, 2019
@ianmcburnie ianmcburnie changed the title Infotip: when content goes out of page boundary Infotip: enhance with viewport boundary detection Feb 16, 2019
@ianmcburnie ianmcburnie added this to the v3.0.0 milestone Jun 19, 2019
@ianmcburnie ianmcburnie removed this from the v3.0.0 milestone Jul 12, 2019
@ianmcburnie ianmcburnie added fellowship: good first project A task that will take a sprint or more with minimal supervision and removed fellowship: good first issue A task that will take a day or more with minimal supervision labels Jul 27, 2020
@PrashantAshok
Copy link
Contributor

@ianmcburnie - I just had a chat with @agliga regarding this - I am running into this issue where the tooltip or infotip gets cuts off - in this case due to a parent having overflow: hidden. For a workaround, I can hardcoded the overlay position based on some condition.

Screen Shot 2021-01-05 at 4 02 34 PM

Can this bug be prioritized so that component has the logic to adjust whenever it is getting cutoff?

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jan 6, 2021

@PrashantAshok Dealing with hidden overflow is a different issue altogether than viewport boundary though, right?

@ianmcburnie
Copy link
Contributor

ianmcburnie commented Jun 16, 2021

Cool looking library found by @PrashantAshok:

https://popper.js.org/

@ianmcburnie
Copy link
Contributor

Here's another: https://www.floating-ui.com/

@PrashantAshok
Copy link
Contributor

that's a nice one - looks like it was written by popper.js folks? And ideally any library that we pick, hopefully should be able to handle #1401 issue as well.

@agliga
Copy link
Contributor

agliga commented Oct 19, 2022

Currently the tour tip is pretty dumb when it comes to positioning. A good solution requires more JS code.
Good examples of adaptive positioning are in TippyJS and the good old qTips2.

@PrashantAshok
Copy link
Contributor

Can we please look into prioritizing this issue along with #1401?

@ianmcburnie
Copy link
Contributor

Anything that isn't directly related to Evo and Core4 is not going to be high on our list. We are probably going to have to rely on a fellowship or open source contribution for these two issues.

@agliga agliga changed the title Infotip: enhance with viewport boundary detection Dropdowns: enhance with viewport boundary detection Jun 5, 2024
@agliga
Copy link
Contributor

agliga commented Jun 5, 2024

Will use this issue to track changing dropdowns to use floating ui

@agliga agliga added this to eBayUI Jun 5, 2024
@agliga agliga self-assigned this Jun 5, 2024
@agliga agliga added the size: 2 label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

5 participants