Skip to content

Commit

Permalink
chore: added comments to drawer and fullscreen dialog about future re…
Browse files Browse the repository at this point in the history
…moval (#2540)
  • Loading branch information
agliga authored Jan 27, 2025
1 parent b6f7744 commit a21d879
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/curvy-experts-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/skin": major
---

chore: added comment to deprecated components about their removal
1 change: 1 addition & 0 deletions dist/drawer-dialog/drawer-dialog.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/*! DEPRECATED COMPONENT. Will be removed next major version */
:root {
--dialog-scrim-color-hide: rgba(17, 24, 32, 0);
--dialog-scrim-color-show: rgba(17, 24, 32, 0.7);
Expand Down
1 change: 1 addition & 0 deletions dist/fullscreen-dialog/fullscreen-dialog.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/*! DEPRECATED COMPONENT. Will be removed next major version */
:root {
--dialog-scrim-color-hide: rgba(17, 24, 32, 0);
--dialog-scrim-color-show: rgba(17, 24, 32, 0.7);
Expand Down
2 changes: 2 additions & 0 deletions src/sass/drawer-dialog/drawer-dialog.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/*! DEPRECATED COMPONENT. Will be removed next major version */

@import "../variables/variables";
@import "../mixins/private/dialog-mixins";
@import "../mixins/private/token-mixins";
Expand Down
4 changes: 2 additions & 2 deletions src/sass/fullscreen-dialog/fullscreen-dialog.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
/*! DEPRECATED COMPONENT. Will be removed next major version */

@import "../variables/variables";
@import "../mixins/private/dialog-mixins";
@import "../mixins/private/token-mixins";

// DEPRECATED (whole component needs to be removed)

.fullscreen-dialog[role="dialog"] {
@include dialog-base();
}
Expand Down

0 comments on commit a21d879

Please sign in to comment.