chore: remove deprecated code for next major (#2536)

eBay · Jan 27, 2025 · c479ee1 · c479ee1
1 parent fa76831
commit c479ee1
Show file tree

Hide file tree

Showing 11 changed files with 7 additions and 568 deletions.
diff --git a/.changeset/late-rats-hope.md b/.changeset/late-rats-hope.md
@@ -0,0 +1,5 @@
+---
+"@ebay/skin": major
+---
+
+chore: remove deprecations for next major version
diff --git a/dist/lightbox-dialog/lightbox-dialog.css b/dist/lightbox-dialog/lightbox-dialog.css
@@ -211,18 +211,6 @@ button.icon-btn.lightbox-dialog__prev {
     opacity: 1;
     transform: translateY(0);
 }
-
-.lightbox-dialog__handle {
-    background-color: initial;
-    border: none;
-    left: 0;
-    margin: -11px auto;
-    padding: 8px;
-    position: relative;
-    right: 0;
-    top: 11px;
-    z-index: 2;
-}
 .lightbox-dialog__handle:after {
     background-color: var(--dialog-handle-color, var(--color-stroke-default));
     border-radius: 3px;
@@ -232,11 +220,6 @@ button.icon-btn.lightbox-dialog__prev {
     width: 24px;
 }
 
-.lightbox-dialog__window--expanded {
-    height: 95%;
-    max-height: 95%;
-}
-
 [dir="rtl"] button.icon-btn.lightbox-dialog__prev .icon--16 {
     transform: rotate(180deg);
 }
@@ -263,20 +246,13 @@ button.icon-btn.lightbox-dialog__prev {
         max-width: 100%;
         width: 100%;
     }
-    .lightbox-dialog--fullscreen .lightbox-dialog__handle,
-    .lightbox-dialog--large .lightbox-dialog__handle {
-        display: none;
-    }
 }
 @media (min-width: 512px) {
     .lightbox-dialog__window {
         border-radius: var(--lightbox-border-radius, var(--border-radius-100));
         margin: auto;
         max-width: calc(88% - var(--spacing-400));
     }
-    .lightbox-dialog__handle {
-        display: none;
-    }
     .lightbox-dialog--narrow .lightbox-dialog__window {
         max-width: var(--dialog-lightbox-narrow-max-width);
     }

diff --git a/dist/skeleton/skeleton.css b/dist/skeleton/skeleton.css
@@ -114,9 +114,6 @@ div.skeleton__text:not(:last-child),
 div.skeleton__textbox:not(:last-child) {
     margin-block-end: var(--spacing-150);
 }
-.skeleton--elevated {
-    --skeleton-background: var(--color-loading-fill-elevated);
-}
 
 .skeleton--on-secondary {
     --skeleton-background: var(--color-loading-fill-on-secondary);
@@ -126,9 +123,6 @@ div.skeleton__textbox:not(:last-child) {
     .skeleton {
         --skeleton-background: var(--color-loading-shimmer);
     }
-    .skeleton--elevated {
-        --skeleton-background: var(--color-loading-shimmer-elevated);
-    }
     .skeleton--on-secondary {
         --skeleton-background: var(--color-loading-shimmer-on-secondary);
     }

diff --git a/dist/table/table.css b/dist/table/table.css
@@ -106,13 +106,7 @@
     text-align: left;
 }
 
-.table-cell--numeric {
-    text-align: right;
-}
-.table__cell {
-    text-align: left;
-}
-
+.table-cell--numeric,
 .table__cell--numeric {
     text-align: right;
 }

diff --git a/src/sass/details/stories/details.stories.js b/src/sass/details/stories/details.stories.js
@@ -69,33 +69,3 @@ export const small = () => `
     <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
 </details>
 `;
-
-// Deprecated stories
-export const closed12pxIcon = () => `
-<details class="details">
-    <summary class="details__summary">
-        <span class="details__label">Details</span>
-        <span class="details__icon" hidden>
-            <svg class="icon icon--12" aria-hidden="true">
-                <use href="#icon-chevron-down-12"></use>
-            </svg>
-        </span>
-    </summary>
-    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
-</details>
-`;
-
-// Deprecated stories
-export const open12pxIcon = () => `
-<details class="details" open>
-    <summary class="details__summary">
-        <span class="details__label">Details</span>
-        <span class="details__icon" hidden>
-            <svg class="icon icon--12" aria-hidden="true">
-                <use href="#icon-chevron-down-12"></use>
-            </svg>
-        </span>
-    </summary>
-    <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.</p>
-</details>
-`;