Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eek): updated size #2463

Merged
merged 2 commits into from
Oct 15, 2024
Merged

feat(eek): updated size #2463

merged 2 commits into from
Oct 15, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 8, 2024

Fixes #2447

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Initially eek needed an icon change which was going to be a bigger change. However, I was able to resize it and it looks pretty good.
  • For the next major we should change the icon but that would be considered breaking
  • The icon provided in the issue was not working (no borders), so will need a new one from design

Screenshots

Screenshot 2024-10-08 at 11 08 24 AM

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Oct 8, 2024
Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 1c60c44

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agliga agliga merged commit a83ea89 into 18.4.0 Oct 15, 2024
@agliga agliga deleted the eek-size branch October 15, 2024 13:51
@github-actions github-actions bot mentioned this pull request Oct 15, 2024
agliga added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants