Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-preview-card): add description #2474

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

LuLaValva
Copy link
Member

Fixes #

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Notes

Screenshots

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@LuLaValva LuLaValva requested a review from ArtBlue October 24, 2024 22:54
@LuLaValva LuLaValva self-assigned this Oct 24, 2024
Copy link

changeset-bot bot commented Oct 24, 2024

🦋 Changeset detected

Latest commit: 529391a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LuLaValva LuLaValva force-pushed the file-preview-card-description branch from 981e94d to 529391a Compare October 25, 2024 16:05
Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need docs changes for this?

@LuLaValva
Copy link
Member Author

Docs changes were in the one that merged to master

@LuLaValva LuLaValva merged commit 67a224b into 18.4.0 Oct 25, 2024
@LuLaValva LuLaValva deleted the file-preview-card-description branch October 25, 2024 16:50
This was referenced Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants