-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature copy results to clipboard #513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great! Just a couple of suggestions in the wording. Thanks for adding tests too! I notice these appear to be failing?
@joewiz yes seems like CI test for copying doesn't work in this environment. |
Co-authored-by: Joe Wicentowski <[email protected]>
Co-authored-by: Joe Wicentowski <[email protected]>
@marmoure I also get the same "Browser context management is not supported" error shown in the CI log when running |
@marmoure Ah, I'm not sure... Is there a way to keep the tests while marking them as "pending" or "don't run"? Perhaps the situation with browser context management will change in the future, and we could just re-enable your tests. Re: #499, this PR is indeed quite similar, but my original idea was to allow copying on a per-item basis, but yours copies the current 10 results as a whole. I don't suppose it would be hard to add a per-item copy function? I'm happy to merge this without that, but I thought I'd ask in case it helps. |
@joewiz can you please elaborate and how that function work When you have multiple results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on today's call, we will merge this as is.
@marmoure Thank you!
while working with eXide and running eval on some scripts i found that copying the results was not easy at all.
![image](https://user-images.githubusercontent.com/30597211/184250717-45a9468f-fd71-403d-9980-86644d45258b.png)
first i can't select it all using ctrl-A as the focus was always on the editor pane and trying to do it with the mouse proven to be a hassle.
i decided to add a copy to clipboard button which copies all the results showing in the results pane.