Revert "display xqlint errors" PR #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fbbde08.
marmoure
approved these changes
Jan 3, 2023
|
seems good to me |
|
@joewiz can i be added to the review team for exide? |
|
@marmoure Sure! I've just invited you to the xquery-contributors team - which covers eXide, among others. |
|
unless anyone sees this PR as unfit i ll merge it in 3 days |
|
@marmoure Thanks! We can actually go ahead and merge it. Removing an unreleased feature shouldn't be very controversial. |
|
@marmoure Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts commit fbbde08, which was from PR #529. That PR allowed xqlint to report any errors to the user. While this is a laudable goal, it was only half of the fix needed to address the original issue that prompted it. The other half that is still needed is to update xqlint's XQuery 3.1 parser. Until eXide's xqlint is updated, eXide issues constant "lexical analysis failed" errors - making it virtually unusable.
Thus, I'd like to revert this PR.
Of course, I also welcome @marmoure to resubmit the PR so that it can be considered when the xqlint issue is fixed. Thank you, Younes!