fix: 21219 Honour ARGOCD_APPLICATIONSET_CONTROLLER_NAMESPACES for all…

… ApplicationSet events Namespace filtering is applied to Update, Delete and Generic events. Fixes argoproj#21219 Signed-off-by: eadred <[email protected]>
eadred · Dec 18, 2024 · b171dcf · b171dcf
1 parent e6b110d
commit b171dcf
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/applicationset/controllers/applicationset_controller.go b/applicationset/controllers/applicationset_controller.go
@@ -525,11 +525,9 @@ func (r *ApplicationSetReconciler) getMinRequeueAfter(applicationSetInfo *argov1
 }
 
 func ignoreNotAllowedNamespaces(namespaces []string) predicate.Predicate {
-	return predicate.Funcs{
-		CreateFunc: func(e event.CreateEvent) bool {
-			return utils.IsNamespaceAllowed(namespaces, e.Object.GetNamespace())
-		},
-	}
+	return predicate.NewPredicateFuncs(func(object client.Object) bool {
+		return utils.IsNamespaceAllowed(namespaces, object.GetNamespace())
+	})
 }
 
 func appControllerIndexer(rawObj client.Object) []string {