Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare CRAN release, try to reduce time for examples #361

Merged
merged 11 commits into from
Jan 23, 2025
Merged

Prepare CRAN release, try to reduce time for examples #361

merged 11 commits into from
Jan 23, 2025

Conversation

strengejacke
Copy link
Member

@strengejacke strengejacke commented Jan 20, 2025 •
edited
Loading

@DominiqueMakowski I accidentally merged the initial submission PR, so I opened a new one. I tried to reduce running time for examples. Let's see if checks pass, and if so, you can submit from this PR.

@strengejacke
Copy link
Member Author

LGTM, I think you can submit

@DominiqueMakowski
Copy link
Member

Eeeerf

Debian: <https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250120_175843/Debian/00check.log>
Status: 2 NOTEs

Last released version's CRAN status: OK: 13
See: <https://cran.r-project.org/web/checks/check_results_modelbased.html>

CRAN Web: <https://cran.r-project.org/package=modelbased>

Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250120_175843/>
The files will be removed after roughly 7 days.

*** Strong rev. depends ***: easystats see

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-windows-x86_64
Check: *, Result: OK


Flavor: r-devel-linux-x86_64-debian-gcc
Check: examples, Result: NOTE
  Examples with CPU (user + system) or elapsed time > 5s
                                            user system elapsed
  visualisation_recipe.estimate_predicted 12.019  0.324   2.477
  estimate_means                           9.181  0.323   1.064
  get_emmeans                              7.718  0.180   1.343
  Examples with CPU time > 2.5 times elapsed time
                                            user system elapsed ratio
  estimate_means                           9.181  0.323   1.064 8.932
  get_emmeans                              7.718  0.180   1.343 5.881
  visualisation_recipe.estimate_predicted 12.019  0.324   2.477 4.983

Flavor: r-devel-linux-x86_64-debian-gcc
Check: tests, Result: NOTE
    Running 'testthat.R' [125s/17s]
  Running R code in 'testthat.R' had CPU time 7.2 times elapsed time

@strengejacke
Copy link
Member Author

Can we somehow find out how long examples now will take on Linux? I guess not, or? I tried to skip a lot more examples now, wrapped into dontrun{} - I hope that these are not tested nor run on CRAN!

@DominiqueMakowski
Copy link
Member

ffs 🫠

Debian: <https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250120_200056/Debian/00check.log>
Status: 2 NOTEs

Last released version's CRAN status: OK: 13
See: <https://cran.r-project.org/web/checks/check_results_modelbased.html>

CRAN Web: <https://cran.r-project.org/package=modelbased>

Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250120_200056/>
The files will be removed after roughly 7 days.

*** Strong rev. depends ***: easystats see

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-windows-x86_64
Check: *, Result: OK


Flavor: r-devel-linux-x86_64-debian-gcc
Check: examples, Result: NOTE
  Examples with CPU time > 2.5 times elapsed time
                  user system elapsed ratio
  estimate_means 2.445  0.083   0.437 5.785
  get_emmeans    2.994  0.075   0.638 4.810

Flavor: r-devel-linux-x86_64-debian-gcc
Check: tests, Result: NOTE
    Running 'testthat.R' [124s/18s]
  Running R code in 'testthat.R' had CPU time 7 times elapsed time

@strengejacke
Copy link
Member Author

What is this ratio all about?

@strengejacke
Copy link
Member Author

https://stackoverflow.com/questions/77323811/r-package-to-cran-had-cpu-time-5-times-elapsed-time

@strengejacke
Copy link
Member Author

Ok, I used this trick to limit the number of CPUs on CRAN - hopefully this will resolve this issue. Also trying to check on RHub

@strengejacke
Copy link
Member Author

rhub doesn't work for me... should we try again, since we now have set the thread limit for CRAN?

@strengejacke strengejacke mentioned this pull request Jan 21, 2025
Merged
@strengejacke
Copy link
Member Author

Allright, I think the next try to submit can start... 😎

@strengejacke
Copy link
Member Author

Shall we submit (with this new setting) or be safe and put some more examples into \dontrun{}? But it feels like we have almost no examples left that are run then... 😬

@DominiqueMakowski
Copy link
Member 

Debian: <https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250122_185940/Debian/00check.log>
Status: 1 NOTE

Last released version's CRAN status: OK: 13
See: <https://cran.r-project.org/web/checks/check_results_modelbased.html>

CRAN Web: <https://cran.r-project.org/package=modelbased>

Please fix all problems and resubmit a fixed version via the webform.
If you are not sure how to fix the problems shown, please ask for help on the R-package-devel mailing list:
<https://stat.ethz.ch/mailman/listinfo/r-package-devel>
If you are fairly certain the rejection is a false positive, please reply-all to this message and explain.

More details are given in the directory:
<https://win-builder.r-project.org/incoming_pretest/modelbased_0.9.0_20250122_185940/>
The files will be removed after roughly 7 days.

*** Strong rev. depends ***: easystats see

Best regards,
CRAN teams' auto-check service
Flavor: r-devel-windows-x86_64
Check: *, Result: OK


Flavor: r-devel-linux-x86_64-debian-gcc
Check: tests, Result: NOTE
    Running 'testthat.R' [49s/17s]
  Running R code in 'testthat.R' had CPU time 2.8 times elapsed time

@strengejacke
Copy link
Member Author

Now we have the same issues with the tests 😔 let's skip some tests on CRAN.

@strengejacke
Copy link
Member Author

strengejacke commented Jan 22, 2025 •
edited
Loading

image

(please try again...)

@strengejacke
Copy link
Member Author

ok, let me fix #363 first, before we try to submit again. I suggest we can keep the string-definitions, and internally coerce to formula for the standard keywords, i.e. when one of these options is used:

String: One of "pairwise", "reference", "sequential", "meandev" "meanotherdev" and the inverse options "revpairwise", "revreference", and "revsequential".

We just coerce it to as.formula(paste("~", <comparison>)).

@strengejacke strengejacke merged commit 6ca6cf7 into main Jan 23, 2025
18 of 22 checks passed
@strengejacke strengejacke deleted the rc_0_9_0b branch January 23, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strengejacke @DominiqueMakowski