Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US1315851 - add new fields to scholar person #29

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ikantaria-eis
Copy link
Collaborator

add following fields to scholar person: totalCoauthoredWorks, totalWorks, totalUniqueCoAuthors, totalWorksWithMultipleContributors, citedByCount

…rks, totalWorks, totalUniqueCoAuthors, totalWorksWithMultipleContributors, citedByCount
Comment on lines 472 to 477
scholar:totalCoAuthoredWorks a rdf:Property ;
rdfs:label "total co-authored works"@en ;
rdfs:comment "The total number of works a person has co-authored."@en ;
rdfs:domain lite:Person ;
rdfs:range xsd:integer .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a property of the edge. Not applicable to the lite:Person as a property. We can handle this use case via named graph or rdf reification.

Suggested change
scholar:totalCoAuthoredWorks a rdf:Property ;
rdfs:label "total co-authored works"@en ;
rdfs:comment "The total number of works a person has co-authored."@en ;
rdfs:domain lite:Person ;
rdfs:range xsd:integer .


scholar:totalWorks a rdf:Property ;
rdfs:label "total works"@en ;
rdfs:comment "The total number of works authored or co-authored by the person."@en ;
Copy link
Contributor

@gmreburn gmreburn Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:comment "The total number of works authored or co-authored by the person."@en ;
rdfs:comment "The total number of works authored or co-authored by the person, as reported by external sources."@en ;


scholar:totalUniqueCoAuthors a rdf:Property ;
rdfs:label "total unique co-authors"@en ;
rdfs:comment "The total number of unique co-authors associated with the person."@en ;
Copy link
Contributor

@gmreburn gmreburn Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:comment "The total number of unique co-authors associated with the person."@en ;
rdfs:comment "The total number of distinct authors with whom the person has collaborated across all their works. This count includes only unique individuals, regardless of the number of joint works."@en ;


scholar:citedByCount a rdf:Property ;
rdfs:label "cited by count"@en ;
rdfs:comment "The number of times the person’s works have been cited."@en ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:comment "The number of times the person’s works have been cited."@en ;
rdfs:comment "The total number of citations the person’s works have received from other scholarly works. This count reflects how many times their contributions have been referenced in academic literature."@en ;

rdfs:label "order"@en ;
rdfs:comment "Specifies the order of a contributor in a work."@en ;
rdfs:domain scholar:Contribution ;
rdfs:range xsd:string .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a number or enum (first, middle, last)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in current case its kind of enum, but I think it should be string and we can use according to needs. (if it changes sometimes later and can be used in other classes as well)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be a positive number, we will discuss tomorrow

data/vocab/scholar.ttl Outdated Show resolved Hide resolved
scholar:totalUniqueCoAuthors a rdf:Property ;
rdfs:label "total unique co-authors"@en ;
rdfs:comment "The total number of distinct authors with whom the person has collaborated across all their works. This count includes only unique individuals, regardless of the number of joint works."@en ; rdfs:domain lite:Person ;
rdfs:range xsd:integer .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:range xsd:integer .
rdfs:range xsd:nonNegativeInteger .

data/vocab/scholar.ttl Outdated Show resolved Hide resolved
data/vocab/scholar.ttl Outdated Show resolved Hide resolved
data/vocab/scholar.ttl Outdated Show resolved Hide resolved
data/vocab/scholar.ttl Outdated Show resolved Hide resolved
data/vocab/scholar.ttl Outdated Show resolved Hide resolved
data/vocab/scholar.ttl Outdated Show resolved Hide resolved
Comment on lines +494 to +500
scholar:contributor a rdf:Property ;
rdfs:label "contributor"@en ;
rdfs:comment "Entity (or entities) who contribute to the origin resource."@en ;
rdfs:domain scholar:Contribution ;
rdfs:range lite:Agent ;
owl:equivalentProperty schema:contributor, dc:contributor .

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in lite, don't need it defined here

Suggested change
scholar:contributor a rdf:Property ;
rdfs:label "contributor"@en ;
rdfs:comment "Entity (or entities) who contribute to the origin resource."@en ;
rdfs:domain scholar:Contribution ;
rdfs:range lite:Agent ;
owl:equivalentProperty schema:contributor, dc:contributor .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lite contributor does not have relation to Contribution. not to affect lot of classes, I thought maybe creating scholar contributor with contribution was required

Copy link
Collaborator

@gloriagonz gloriagonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ContributorStatement label

data/vocab/scholar.ttl Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants