Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade python from 3.12-slim to 3.13.0b3-slim #7

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

johnnyhuy
Copy link
Collaborator

@johnnyhuy johnnyhuy commented Jul 21, 2024

User description

This PR was automatically created by Snyk using the credentials of a real user.


![snyk-top-banner](https://github.com/andygongea/OWASP-Benchmark/assets/818805/c518c423-16fe-447e-b67f-ad5a49b5d123)

Snyk has created this PR to fix 3 vulnerabilities in the dockerfile dependencies of this project.

Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.

Snyk changed the following file(s):

  • Dockerfile

We recommend upgrading to python:3.13.0b3-slim, as this image has only 43 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Integer Overflow or Wraparound
SNYK-DEBIAN12-ZLIB-6008963
  500  
low severity CVE-2023-50495
SNYK-DEBIAN12-NCURSES-6123823
  150  
low severity CVE-2023-50495
SNYK-DEBIAN12-NCURSES-6123823
  150  
low severity CVE-2023-45918
SNYK-DEBIAN12-NCURSES-6252773
  150  
low severity CVE-2023-45918
SNYK-DEBIAN12-NCURSES-6252773
  150  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.


PR Type

Bug fix, Enhancement


Description

  • Upgraded the Docker base image from python:3.12-slim to python:3.13.0b3-slim to address multiple vulnerabilities.
  • Fixed vulnerabilities including Integer Overflow or Wraparound and several CVEs related to ncurses.

Changes walkthrough 📝

Relevant files
Dependencies
Dockerfile
Upgrade Python base image to reduce vulnerabilities           

Dockerfile

  • Upgraded base image from python:3.12-slim to python:3.13.0b3-slim
  • +1/-1     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @echohello-codium-ai-pr-agent
    Copy link

    echohello-codium-ai-pr-agent bot commented Jul 21, 2024

    PR Review 🔍

    (Review updated until commit 2e2cd9c)

    ⏱️ Estimated effort to review [1-5]

    1, because the PR contains a simple version bump in the Dockerfile which is straightforward to evaluate.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Possible Stability Issue: The PR upgrades the Python image to a beta version (3.13.0b3-slim), which might not be as stable as a full release. This could introduce unexpected behaviors or bugs in the application.

    🔒 Security concerns

    No

    @echohello-codium-ai-pr-agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Pin specific versions of packages to ensure consistent builds

    Consider pinning the version of ffmpeg and curl to ensure consistent, predictable builds
    and avoid potential incompatibilities with untested newer versions.

    Dockerfile [3]

    -RUN apt-get update && apt-get install -y ffmpeg curl
    +RUN apt-get update && apt-get install -y ffmpeg=4.3.1-0+deb10u1 curl=7.64.0-4+deb10u1
     
    Suggestion importance[1-10]: 9

    Why: Pinning specific versions of ffmpeg and curl is a best practice to ensure consistent and predictable builds, avoiding potential issues with newer, untested versions.

    9

    @johnnyhuy johnnyhuy closed this Jul 21, 2024
    @johnnyhuy johnnyhuy reopened this Jul 21, 2024
    @github-actions github-actions bot added the feature Produce features label Jul 21, 2024
    @echohello-codium-ai-pr-agent
    Copy link

    Persistent review updated to latest commit 2e2cd9c

    @echohello-codium-ai-pr-agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Replace the beta version of the Python image with a stable release

    Consider pinning the version of the base image to a stable release instead of a beta
    version to ensure the reliability and stability of your application.

    Dockerfile [1]

    -FROM python:3.13.0b3-slim
    +FROM python:3.13-slim
     
    Suggestion importance[1-10]: 9

    Why: Pinning the version of the base image to a stable release instead of a beta version is a best practice to ensure the reliability and stability of the application. This suggestion addresses a significant concern.

    9

    @johnnyhuy johnnyhuy merged commit d527504 into main Jul 21, 2024
    7 checks passed
    @johnnyhuy johnnyhuy deleted the snyk-fix-d89add38aef1fd01b34ac9cd55df7767 branch July 21, 2024 08:11
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants