-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two missing configuration for Apache - DefaultAuthSchemeRegistry … #4686
base: 2.x
Are you sure you want to change the base?
Add two missing configuration for Apache - DefaultAuthSchemeRegistry … #4686
Conversation
…and RedirectStrategy Signed-off-by: Nicholas DiPiazza <[email protected]>
There is a valid ECA on file for [email protected]. But check fails for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide some tests for those changes?
And when editing those files, could you please modify Copyright year on top of each file to be 2021 (instead 2020 for example)? The 2nd CP year shell be modified.
...rs/apache-connector/src/main/java/org/glassfish/jersey/apache/connector/ApacheConnector.java
Show resolved
Hide resolved
...rs/apache-connector/src/main/java/org/glassfish/jersey/apache/connector/ApacheConnector.java
Show resolved
Hide resolved
...rs/apache-connector/src/main/java/org/glassfish/jersey/apache/connector/ApacheConnector.java
Show resolved
Hide resolved
...he-connector/src/main/java/org/glassfish/jersey/apache/connector/ApacheClientProperties.java
Show resolved
Hide resolved
...rs/apache-connector/src/main/java/org/glassfish/jersey/apache/connector/ApacheConnector.java
Show resolved
Hide resolved
@senivam I am trying to add a unit test, but the master branch will not compile. Is there some quick contributing eclipse/intellij setup guide so i can get a workspace set up? |
@nddipiazza if you previously compiled the branch (using JDK 8 for example) and now it does not pass again you can try to remove all target/* folders and compile it again using same JDK. If this does not help it's possible to clean local .m2/repository/org/glassfish/jersey folder and build jersey again. BTW, we have another approach of supplying parameters which are not explicitly indicated in properties to Apache connector which is manual implementing of ApacheHttpClientBuilderConfigurator SPI interface and passing all required properties via custom |
Yep the .m2 repositories thing fixed it. Weird. |
Add two missing configuration for Apache HTTP client properties:
These are blockers for several use cases.
In particular, without the ability to update the default auth scheme registry, you cannot do Spnego AuthScheme.