Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate flaky test fixes same as this PR: #5764
I found two additional instances of the
testDisposeComposedObjectWithPerLookupFields()
test which sometimes fail under non-deterministic behavior. I used the same fix as the one in the PR above, using a HashSet comparison to check the strings within theComposedObject
.You can reproduce this error using the https://github.com/TestingResearchIllinois/NonDex tool, which explores and reports errors in different behaviors of under-determined Java APIs.
To reproduce this problem, you can run the test with NonDex using these commands after building:
Here are screenshots of the output produced by NonDex before and after the fix for the first test case:
Please let me know if you want to discuss these changes.