Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix convert to lambda for one statement that has non-NLS marker #2000

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

jjohnstn
Copy link
Contributor

@jjohnstn jjohnstn commented Feb 5, 2025

What it does

See issue.

How to test

See issue or new test.

Author checklist

- modify LambdaExpressionsFixCore to not convert a single
  expression statement into a lambda specifying expression if the
  statement has a line comment such as a non-NLS marker
- add new test to CleanUpTest1d8
- fixes eclipse-jdt#1999
@jjohnstn jjohnstn self-assigned this Feb 5, 2025
@jjohnstn jjohnstn added the bug Something isn't working label Feb 5, 2025
@jjohnstn jjohnstn added this to the 4.35 M3 milestone Feb 5, 2025
@jjohnstn jjohnstn merged commit 0aacc6d into eclipse-jdt:master Feb 6, 2025
10 checks passed
@jjohnstn jjohnstn deleted the lambdanls branch February 6, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to lambda sometimes removes non-NLS marker comments
1 participant