Remove MaximumQoS property from CONNECT packet #161 #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create a Pull Request without creating an issue first
#161 was created related to this request.
The design of your solution to the problem should be discussed and agreed in an issue before submitting the PR
According to MQTTv5 spec, Maximum QoS property should not be included in CONNECT packet. Actually, when I tried to send CONNECT packet included that property to Mosquitto MQTT server, the connection was refused by Mosquitto. So, I think we should remove Maximum QoS property from CONNECT packet in this library.
note: This request is same with #240, but I remaked the request after some confirmations, because there was a problem with test on my envrionment (#242). As a result, the problem wasn't probably related to this change.
ECA - Eclipse Contributer Agreement
had already done
Testing
make test
was passed. I sometimes catched an issue with An autopaho test TestQueuedMessage may be not passed. #242, but tests were passed temporarily with making the timeout of autopaho's cm longer.Closing issues
closes #161