feat(importCDX): enhance component VCS naming convention for improved consistency #2744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistency Signed-off-by: Sameed <[email protected]>
sameed20
requested review from
heliocastro,
GMishx,
KoukiHama,
arunazhakesan and
ag4ums
as code owners
sameed20
added
needs code review
needs general test
heliocastro
reviewed
Nov 27, 2024
|
We can extract the domain specific logic in a dedicated class file which will also allow us to add more domains in the future and/or identify commonalities between different domain repository URL structures to arrive at a more generalized solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR introduces improvements to the naming convention of components by leveraging the VCS (Version Control System) field. By utilizing this field, the component names will now be more descriptive and reflective of their origins, ensuring less duplicity of components and also maintaining the DB integrity.