server: Make client context available in de-registration callback #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rettichschnidi
requested changes
Jul 6, 2022
Remove the client context from server only after calling the monitoring callback when handling a de-registration. A as result, the client information is still available in the server context during the callback. Signed-off-by: Marc Lasch <[email protected]>
mlasch
force-pushed
the
gardena/ml/client-unregister-context
branch
from
18f08f9 to
715f274
Compare
rettichschnidi
requested changes
Mar 3, 2023
| break; | ||
|
|
||
| default: | ||
| fprintf(stdout, "\r\nMonitor callback called with an unknown status: %d.\r\n", status); | ||
| break; | ||
| } | ||
| prv_dump_client(clientP); |
There was a problem hiding this comment.
Is it intended to do this even when returning COAP_202_DELETED?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the client from server context only after calling the monitoring callback when handling a de-registration. A as result, the client information is still available in the server context during the callback.
Signed-off-by: Marc Lasch [email protected]