Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce C headers in data #765

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

LukasWoodtli
Copy link
Contributor

This is a small step in making a more modular and maintainable C project.

@LukasWoodtli LukasWoodtli force-pushed the lw/introduce_headers_in_data branch from a3f5f8a to 6019edd Compare April 23, 2024 09:59
data/cbor.c Outdated Show resolved Hide resolved
data/json_common.h Outdated Show resolved Hide resolved
@LukasWoodtli LukasWoodtli force-pushed the lw/introduce_headers_in_data branch from 6019edd to 51bafce Compare April 25, 2024 10:08
@LukasWoodtli LukasWoodtli changed the title Introduce headers in data Introduce C headers in data Jul 10, 2024
@LukasWoodtli LukasWoodtli force-pushed the lw/introduce_headers_in_data branch 2 times, most recently from b6f6c38 to eac856b Compare July 10, 2024 12:52
There was the macro `LWM2M_VERSION_1_1` to make a distinction between
LwM2M version 1.1 and 1.1.1.
This was removed to make the code easier to maintain.
Some tests can not be compiled if the corresponding defines are not set.
They are only enabled if these preprocessor macros are defined.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
This makes the project more modular and better to maintain.
@LukasWoodtli LukasWoodtli force-pushed the lw/introduce_headers_in_data branch from eac856b to 26cf15a Compare August 1, 2024 05:45
Copy link

sonarqubecloud bot commented Aug 1, 2024

Comment on lines +14 to +15
* Contributors:
* Lukas Woodtli, GARDENA GmbH - Please refer to git log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to keep this for new files? I think it is not useful, or even worse.

Comment on lines +9 to +12
* The Eclipse Public License is available at
* http://www.eclipse.org/legal/epl-v20.html
* The Eclipse Distribution License is available at
* http://www.eclipse.org/org/documents/edl-v10.php.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about starting to use SPDX identifiers? If you agree, I'll create a PR to migrate all existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants