remove the quick fix from estimation parameters (#552)

HARK/SolvingMicroDSOPs/Calibration/EstimationParameters.py

@@ -4,22 +4,6 @@
 '''
 from __future__ import print_function
 
-# ---------------------------------------------------------------------------------
-# Debugging flags
-# ---------------------------------------------------------------------------------
-
-show_PermGroFacAgg_error = False  
-# Error Notes:
-# This sets a "quick fix" to the error, AttributeError: 'TempConsumerType' object has no attribute 'PermGroFacAgg'
-# If you set this flag to "True" you will see the error. A more thorough fix is to
-# fix the place where this error was introduced (Set to "True" and it will appear;  
-# this was almost certainly introduced when the code was extended to be used in the 
-# GE setting). An even more thorough solution, which moves beyond the scope of 
-# fixing this error, is adding unit tests to ID when changes to some code will 
-# break things elsewhere. 
-# Note: alternatively, decide that the "init_consumer_objects['PermGroFacAgg'] = 1.0"
-# line below fixes it properly ('feature not a bug') and remove all this text. 
-
 # ---------------------------------------------------------------------------------
 # - Define all of the model parameters for SolvingMicroDSOPs and ConsumerExamples -
 # ---------------------------------------------------------------------------------
@@ -159,12 +143,6 @@
                         'CubicBool':CubicBool
                         }
 
-if show_PermGroFacAgg_error:
-    pass # do nothing
-else:
-    print("***NOTE: using a 'quick fix' for an attribute error. See 'Error Notes' in EstimationParameter.py for further discussion.***")
-    init_consumer_objects['PermGroFacAgg'] = 1.0
-
 
 if __name__ == '__main__':
     print("Sorry, EstimationParameters doesn't actually do anything on its own.")