fix(ci): Move differential shellcheck to its own workflow

It is not supported in scheduled runs, and fails. Use unique key for shellcheck group Signed-off-by: Edwin Török <[email protected]>
edwintorok · Feb 29, 2024 · 130d7b9 · 130d7b9
1 parent b27ecda
commit 130d7b9
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 22 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -12,28 +12,6 @@ concurrency:  # On new push, cancel old workflows from the same PR, branch or ta
   cancel-in-progress: true
 
 jobs:
-  # https://www.shellcheck.net/wiki/GitHub-Actions
-  # https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
-  shell-test:
-    name: Differential ShellCheck
-    runs-on: ubuntu-latest
-
-    permissions:
-      security-events: write
-
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-        with:
-            fetch-depth: 0
-
-# If needed severity levels can be controlled here
-#            severity: warning
-      - name: Differential ShellCheck
-        uses: redhat-plumbers-in-action/differential-shellcheck@v5
-        with:
-            token: ${{ secrets.GITHUB_TOKEN }}
-
   python-test:
     name: Python tests
     runs-on: ubuntu-22.04

diff --git a/.github/workflows/shellcheck.yaml b/.github/workflows/shellcheck.yaml
@@ -0,0 +1,32 @@
+name: ShellCheck
+
+on:
+  push:
+  pull_request:
+
+concurrency:  # On new push, cancel old workflows from the same PR, branch or tag:
+  group: sc-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  # https://www.shellcheck.net/wiki/GitHub-Actions
+  # https://github.com/redhat-plumbers-in-action/differential-shellcheck?tab=readme-ov-file#usage
+  shell-test:
+    name: Differential ShellCheck
+    runs-on: ubuntu-latest
+
+    permissions:
+      security-events: write
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+        with:
+            fetch-depth: 0
+
+# If needed severity levels can be controlled here
+#            severity: warning
+      - name: Differential ShellCheck
+        uses: redhat-plumbers-in-action/differential-shellcheck@v5
+        with:
+            token: ${{ secrets.GITHUB_TOKEN }}