Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.16](backport #6030) [CI] Buildkite integration tests: Windows ess retry script #6294

Open
wants to merge 3 commits into
base: 8.16
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 12, 2024

What does this PR do?

Adds ess.ps1 script that controls ess deployments for windows tests. If a test retried, it will spin up a new ESS deployment for the retried test group for better reproducibility.

Improves log integration tests log messages

Build examples:

Retried test on Windows(simulated test failure)

  • On the 1st run it uses the shared ESS deployment
  • On the 2nd run it created its own deployment and destroyed it in the end

Positive scenario without retries and simulated test failures
Logs structure is refactored

Why is it important?

That allows to retry Windows tests in an isolated environment

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #6030 done by [Mergify](https://mergify.com).

* ess.ps1

* Cleanup

* Cleanup

* cleanup

---------

Co-authored-by: Geoff Rowland <[email protected]>
(cherry picked from commit 0c4e7a9)

# Conflicts:
#	.buildkite/scripts/integration-tests.ps1
@mergify mergify bot added the backport label Dec 12, 2024
@mergify mergify bot requested a review from a team as a code owner December 12, 2024 10:34
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Dec 12, 2024
@mergify mergify bot assigned pazone Dec 12, 2024
Copy link
Contributor Author

mergify bot commented Dec 12, 2024

Cherry-pick of 0c4e7a9 has failed:

On branch mergify/bp/8.16/pr-6030
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit 0c4e7a904a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .buildkite/scripts/steps/ess.ps1

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   .buildkite/scripts/integration-tests.ps1

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@oakrizan oakrizan removed the conflicts There is a conflict in the backported pull request label Dec 12, 2024
@oakrizan oakrizan self-assigned this Dec 12, 2024
@oakrizan
Copy link
Contributor

Waiting for https://buildkite.com/elastic/elastic-agent-extended-testing-bk/builds/344 to complete successfully before merging.

@oakrizan oakrizan marked this pull request as draft December 12, 2024 15:18
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

2 similar comments
Copy link
Contributor Author

mergify bot commented Dec 23, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

Copy link
Contributor Author

mergify bot commented Dec 30, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@michalpristas michalpristas marked this pull request as ready for review January 2, 2025 09:05
@jlind23 jlind23 enabled auto-merge (squash) January 2, 2025 10:19
@jlind23 jlind23 requested a review from a team as a code owner January 2, 2025 10:19
@jlind23 jlind23 requested review from kaanyalti and andrzej-stencel and removed request for a team January 2, 2025 10:19
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants