Fix AGENT_COMMIT_OVERRIDE environment variable name #6530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR elastic#4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash
pchila
added
bug
|
Pinging @elastic/elastic-agent (Team:Elastic-Agent) |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
|
|
pchila
added
backport-8.x
jlind23
approved these changes
Jan 16, 2025
rowlandgeoff
approved these changes
Jan 16, 2025
|
michalpristas
approved these changes
Jan 17, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca)
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca)
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca)
pkoutsovasilis
pushed a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca) Co-authored-by: Paolo Chilà <[email protected]>
pkoutsovasilis
pushed a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca) Co-authored-by: Paolo Chilà <[email protected]>
pchila
added a commit
that referenced
this pull request
Jan 17, 2025
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect. This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash (cherry picked from commit 28117ca) Co-authored-by: Paolo Chilà <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In PR #4403 a new environment variable has been introduced to use a commit hash consistent with the hash of the elastic-agent-core DRA binary used. The env var name was not initialized and ended up using "MANIFEST_URL" which is obviously incorrect.
This commit sets the correct name AGENT_COMMIT_OVERRIDE to avoid using the manifest url as a commit hash
Why is it important?
It allows for testing elastic-agent packaging with commands like
Checklist
[ ] I have read and understood the pull request guidelines of this project.[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself