-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Android assets packaging project and process #3007
Draft
jmartinesp
wants to merge
9
commits into
livekit
Choose a base branch
from
misc/add-android-packaging-module
base: livekit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+581
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4883f90
to
2c5be92
Compare
2c5be92
to
083b1cc
Compare
083b1cc
to
0ce2b20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is everything we'd need to publish the Android assets as an AAR:
platforms/android
folder which contains the Android project with the minimum of changes needed to publish the library as an AAR into the GH gradle registry.publish_android
job that will call this script and automate the publishing.There is still the need to update the version in the
gradle.properties
file before a release so it matches the EC one. That can probably be done later either manually, through some script that changes the version for both, or with a script that extracts the value frompackage.json
and overrides it here (although the value there seems to be0.0.0
?).Note this PR still needs the relative paths for assets to work.