[TMZ-249] remove messages when running first step of the wizard #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicoladj77
commented
Dec 15, 2024
nicoladj77
commented
- Enforce minimum core dependency
- fix saas warnings
- remove messages when running first step of the wizard
…as warnings, remove messages when running first step of the wizard
nuritsha
requested changes
Dec 16, 2024
| @@ -206,6 +206,7 @@ private function __construct() { | |||
| } | |||
|
|
|||
| register_activation_hook( HELLOPLUS_PLUGIN_BASE, [ $this, 'activate' ] ); | |||
|
|
|||
|
|
||
| $plugin_version = $plugin_data['Version']; | ||
|
|
||
| if ( version_compare( $plugin_version, '3.25.11', '<' ) ) { |
There was a problem hiding this comment.
To simplify future maintenance, please use a const, and define it in hello-plus.php, the same value should be used in the condition and the error message.
| @@ -13,6 +13,24 @@ public function install_and_activate() { | |||
| } | |||
|
|
|||
| public function activate() { | |||
| $plugin_file = WP_PLUGIN_DIR . '/elementor/elementor.php'; | |||
|
|
|||
| if ( file_exists( $plugin_file ) ) { | |||
There was a problem hiding this comment.
please extract this logic to a method
nicoladj77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.