ZigZag Entrance Animation [TMZ-216] #153
Open
+403
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # modules/content/classes/render/widget-zig-zag-render.php # webpack.config.js
…zag-entrance-animation
nuritsha
requested changes
Jan 7, 2025
modules/content/widgets/cta.php
Outdated
Comment on lines
49
to
52
| public function get_script_depends(): array { | ||
| return [ 'helloplus-content-fe' ]; | ||
| } | ||
|
|
There was a problem hiding this comment.
I think this was an older version. Removing it.
modules/content/widgets/hero.php
Outdated
Comment on lines
51
to
54
| public function get_script_depends(): array { | ||
| return [ 'helloplus-content-fe' ]; | ||
| } | ||
|
|
Comment on lines
62
to
75
| $is_even = $remainder === $key % 2; | ||
|
|
||
| $item_class = self::ITEM_CLASSNAME; | ||
|
|
||
| $item_class .= ' row' . ( $is_even ? '-even' : '-odd' ); | ||
|
|
||
| $is_even_index = 0 === ( $key + 1 ) % 2; | ||
|
|
||
| if ( $has_alternate_icon_color && $is_even_index ) { | ||
| $item_class .= ' has-alternate-icon-color'; | ||
| } | ||
|
|
||
| $wrapper_classnames = 'ehp-zigzag__item-wrapper'; | ||
|
|
There was a problem hiding this comment.
I don't think we need the row-odd / row-even classes anymore
| } | ||
|
|
||
| $this->widget->add_render_attribute( 'zigzag-item-wrapper-' . $key, [ | ||
| 'class' => $wrapper_classnames, |
There was a problem hiding this comment.
$wrapper_classnames should be an array
Comment on lines
56
to
57
| $remainder = 'left' === $first_zigzag_direction ? 1 : 0; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.