Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android firefox touch is offset by size of address bar #1558

Open
ikke-t opened this issue Feb 1, 2023 · 11 comments · May be fixed by #2475
Open

android firefox touch is offset by size of address bar #1558

ikke-t opened this issue Feb 1, 2023 · 11 comments · May be fixed by #2475

Comments

@ikke-t
Copy link

ikke-t commented Feb 1, 2023

Hi,

gorgeous app, thanks! I was wondering how I can't hit the buttons at the bottom of screen, or bottom of toot input box. Then I noticed that touch placement is off by size of auto-hiding address bar of firefox.

So in my one+ 8 I use FF for web. I tried the latest version at main.elk.zone. I first noticed it while I tried hitting the language selection, I could not hit it. It always opened wrong view. After moment I realized I have to scroll page a bit to get address bar visible from FF, and then I manage to hit the button. I can also hit little above the button, and it works.

I believe the app doesn't calculate the size of screen, it is not realizing FF autohides the address bar.

@stackblitz
Copy link

stackblitz bot commented Feb 1, 2023

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@edimitchel
Copy link
Collaborator

I got the same issue a while ago!

I think it's a FF mobile app issue...

@ikke-t
Copy link
Author

ikke-t commented Feb 2, 2023

FF is my daily browser. I haven't seen such an error on any other page.

Elk has also other drawing errors. If I edit a post on my same mobile, the edit box is drawn behind the keyboard. So I can not see what I should be editing. It shows the original text though. So it's missing slight scroll down after pressing edit so that the edit text box would be visible.

I don't run into such on other pages either.

@johnsonm
Copy link

johnsonm commented Feb 2, 2023

I just close my #1292 in favor of this issue which is clearly what the problem I encountered was.

@edimitchel
Copy link
Collaborator

I thought the same but I don't think it's tight to the elk application.
I tried to reproduce the footer at the bottom and I was enable to reproduce the issue outside of the elk application.
I'll share the link of a reproduction.

@beejunk
Copy link

beejunk commented Feb 4, 2023

I can confirm this behavior, and currently am keeping the address bar pinned to the screen (as opposed to auto-hiding on scroll) in order to avoid this.

I've experienced this issue on other apps that have sticky elements, as well. My guess is that the Firefox auto-hiding toolbar messes with how these elements are detecting where they are positioned on the screen.

@edimitchel
Copy link
Collaborator

Duplicate of #368

@edimitchel edimitchel marked this as a duplicate of #368 Feb 15, 2023
@forresto
Copy link

Looked at the positioning with remote debugging.

Scrolling down, the sticky bottom nav gets off:

Nav notifications hit area:

Scrolling back up, it lines back up:

This supports the "off by url bar" theory.

@ikke-t
Copy link
Author

ikke-t commented Feb 27, 2023

Thanks, BTW, there is a selection in FF for address bar location. Mine is at the bottom of the screen, so it's off to another direction.

@mogul
Copy link

mogul commented Mar 22, 2023

Confirmed, and this also affects the positioning of the drawn caret when editing text... It will be offset by the height of the bar, even when the cursor is in the right place. (I get around this by sliding my finger left and right on the Gboard spacebar to position the cursor.)

zmc added a commit to zmc/elk that referenced this issue Nov 16, 2023
I could be missing something, but this fixes the bottom nav bar for me on mobile in Firefox, doesn't regress in Chrome, and doesn't affect the desktop layout.

resolve elk-zone#1558
@zmc zmc linked a pull request Nov 17, 2023 that will close this issue
@zmc
Copy link

zmc commented Feb 19, 2024

I'd filed a PR with a fix that works for me, but it doesn't seem like it will be accepted. I've created a userstyle that simply sets position: fixed in case it might help others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants