update: use instance's translation service #2426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I think we shouldn't remove the current implementation, as not all Mastodon server would support that API. Instead, we could use it when available and fallback to the current one. |
|
Hi! I've added a condition to use instance's translation provider only when the instance provides the option. However, the method used to test if the instance supports it seems not so graceful. I haven't come up with a better solution yet. Maybe you'll have any ideas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Mastodon v4.0.0, post translation api is exposed at
/api/v1/statuses/:id/translateas well as throughmastopackage. Thus we can use instance's translation service as Elk's translation provider.