Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix request scheme, host and port in req record #110

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix request scheme, host and port in req record #110

wants to merge 3 commits into from

Conversation

tsloughter
Copy link
Member

No description provided.

@tsloughter tsloughter requested a review from a team February 19, 2022 14:50
@tsloughter tsloughter changed the title fix request scheme which was always undefined fix request scheme, host and port in req record Feb 19, 2022
@tsloughter
Copy link
Member Author

Tests were failing on 21 because of the lack of uri_string, so I've ditched support of OTP-21. Fixes #103

@tsloughter tsloughter force-pushed the fix-scheme branch 3 times, most recently from 57532cb to 96dadba Compare February 19, 2022 21:21
yurrriq
yurrriq requested changes Feb 22, 2022
View reviewed changes
Copy link
Member

@yurrriq yurrriq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. my only request is that we bump the major version and mention parse_path/1 -> parse_path/3 etc in the changelog

@yurrriq
Copy link
Member

yurrriq commented Feb 22, 2022

I see dialyzer is mad too. I can probably take a look tonight.

@tsloughter
Copy link
Member Author

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

@yurrriq
Copy link
Member

yurrriq commented Feb 24, 2022

parse_path isn't meant to be a public api, but only for exported for tests, so I don't think this warrants a major version bump.

I'm convinced.

That said, you already started on a major version bump, right? I figured it would go with that anyway.

We have this outdated one at least: #102

@yurrriq yurrriq mentioned this pull request Feb 24, 2022
Draft
@albertocsouto albertocsouto mentioned this pull request Jul 2, 2024
Closed
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Sep 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurrriq yurrriq yurrriq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsloughter @yurrriq