Add SMT-LIB theory of floating point numbers: Part I #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an initial implementation of FloatingPointExpr based on the SMT-LIB FloatingPoint theory. While I’ve reviewed the SMT-LIB documentation, I’m still familiarizing myself with SMT-LIB format, so the implementation would need refinement. I plan to add more correctness checks and implement any the essential features (based on SMT-LIB) in future updates.
I would appreciate feedback to better understand the current state of this PR and identify the next steps to align it with the rest of the API. Additionally, I anticipate needing another PR to focus on interoperability between
FloatingPointExpr,
IntExpr,
BitVectorExpr
, andRealExpr
as that is not done in this PR (although there is basic conversion fromIntExpr
toFPExpr
andRealExpr
toFPExpr
, which will also require unit testing.Please help review this PR, thank you!
Edit:
After re-reading the SMT specification, it seems that conversion to/from other sorts needs to be further polished. I have not used
BitVectorExpr
as some specification also uses this type as well