-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete read_entry_data method from class ComponentCatalogConnector #3141
Conversation
Signed-off-by: Patrick Titzler <[email protected]>
Signed-off-by: Patrick Titzler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't take these changes for a spin, but they look good. Thanks @ptitzler.
Hello @lresende @caponetto There is some note in the code of Elyra 4 here ... but I am unsure conceptually what Patrick wanted to achieve back then. Just seeing this is part of the release 4.0 tracker ... just trying to understand what this code here was :-) |
@lresende looks like this PR has broken the CI. |
…talogConnector (elyra-ai#3141)" This reverts commit a60ae72. This is breaking the build as it seems its not complete yet.
…talogConnector (elyra-ai#3141)" This reverts commit a60ae72. This is breaking the build as it seems its not complete yet. Signed-off-by: Luciano Resende <[email protected]>
…talogConnector (elyra-ai#3141)" This reverts commit a60ae72. This is breaking the build as it seems its not complete yet. Signed-off-by: Luciano Resende <[email protected]>
…talogConnector (elyra-ai#3141)" This reverts commit a60ae72. This is breaking the build as it seems its not complete yet. Signed-off-by: Luciano Resende <[email protected]>
I have two fixes for this, one reverting the changes from #3141 in #3266 and another one with disabling the obsolete tests in #3267 . Which one should we pick @caponetto @shalberd |
@lresende @caponetto I'd go with the approach in PR 3267, that is: Fix CI without reverting removal of read_entry_data. |
It looks like several tests depend on catalogs that are not working with this change, so I will have to revert it for now. |
…ector (#3141) (#3266) * Revert "Remove obsolete read_entry_data method from class ComponentCatalogConnector (#3141)" This reverts commit a60ae72. This is breaking the build as it seems its not complete yet. Signed-off-by: Luciano Resende <[email protected]> * Update yarn.lock Signed-off-by: Luciano Resende <[email protected]> * Pin mistune Signed-off-by: Luciano Resende <[email protected]> --------- Signed-off-by: Luciano Resende <[email protected]>
Closes #2514
What changes were proposed in this pull request?
How was this pull request tested?
elyra-examples-kfp-catalog==0.1.0
)Developer's Certificate of Origin 1.1