-
Notifications
You must be signed in to change notification settings - Fork 31
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Param handing rework and general refactor (#138)
* Update documentation * Update README * Remove extraneous/outdated files * Update checks documentation and tests * Refactor for simplicity This commit changes a lot. Essentially, it's a migration away from the shoe-horned module structure we had before (cmd), since it doesn't really make sense for us to split into submodules with a relatively small project. It's also using a struct with more descriptive fields for all the checks, which also permits us to use reflection to call the functions rather than the grotesque case statements. * Use compilation directive, and add cli options This permits people to use directories other than /opt and C:\ when testing aeacus. * Fix path to stopscoring.sh * Reduce redundancy in gen-crypto * Update build file go version * Fix crypto failing on some checks (UserExists) This was annoying. I was using XOR as the final operation after AES, which I can only assume caused issues with some bytes when XOR'd again and decrypted with AES-GCM. The solution was to put AES-GCM as the final operation, which is also just smarter, since it's an authenticated cipher. This commit also refactors readData() into readScoringData(), since the abstraction there wasn't used anywhere else. * Update go modules and remove verbose messages * Restore crypto.go after make release * Don't count penalties as scored vulnerabilities * Simplify check status handling, fix typos * Remove condition fields, implement param checking There's now a function that will check that the required parameters are being used for a check. * Remove extraneous printing of variable * Changelog and compatibility aliases * Fix build issue arising from `checkTrace` * Add more compiling and crypto information * Rewrite crypto.md to be more approachable * Don't use magic numbers in negation check * Fix info types in README * Add inline SecurityPolicy check documentation * Refactored shell feature (#139) * linux shell revamp, proof of concept * windows shell revamp, proof of concept using conpty * add shell goroutine to runtime * remove old shell functionality * modified shell code to work with new refactor * Use implicit build directives for shell * Add PasswordHistorySize to ranged SecPol checks Thanks to KaliPatriot for pointing this fix out. * Use upstream constants for BitLocker * Remove destroyImage functionality, update Go * Add regex documentation * Added sour's changes + linted them. Co-authored-by: Safin Singh <[email protected]> Co-authored-by: Alvin Zheng <[email protected]> Co-authored-by: mob <[email protected]>
- Loading branch information
1 parent
9d720d2
commit 664ea51
Showing
64 changed files
with
3,602 additions
and
4,007 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.