rp235x: fix atomics, fix SIO spinlock stuck bug, fix missing core1 reset. #3851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like RP2040. The bug was "working as intended" on rp2040, so it is on rp235x.
Dirbaio
force-pushed
the
rp23-atomics-fix
branch
from
f89eeba to
2c965a9
Compare
Dirbaio
force-pushed
the
rp23-atomics-fix
branch
from
2c965a9 to
9da04cc
Compare
jannic
reviewed
Feb 6, 2025
Comment on lines
+654
to
+658
| pac::SIO.spinlock(31).write_value(1); | ||
|
|
||
| // We can still use PSM to reset PROC1 since it comes after PROC0 in the state machine. | ||
| pac::PSM.frce_off().write_and_wait(|w| w.set_proc1(true)); | ||
| pac::PSM.frce_off().write_and_wait(|_| {}); |
There was a problem hiding this comment.
This contains a tiny race condition: Whatever still runs on core 1 may acquire the spinlock after we unlocked it, before core 1 gets reset. So maybe reset core 1 first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3839