i.MX6ul updates #20
Open
i.MX6ul updates #20
+242
−2,209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfeathers
requested review from
lionel,
luckshot,
ts-kris and
randytsi369
luckshot
previously approved these changes
Feb 11, 2025
ts-kris
requested changes
Feb 11, 2025
| "chrg_pct=60\0" \ | ||
| "chrg_verb=0\0" \ | ||
| "silochargeon=silabs scaps disable;" \ | ||
| "if test $silopresent = '1';" \ | ||
| "then if test $jpnochrg = 'off';" \ | ||
| "then silab scaps enable;"\ | ||
| "fi;"\ | ||
| "fi;\0" \ | ||
| "silowaitcharge=if test $silopresent = '1';" \ | ||
| "then if test $jpnochrg = 'on';" \ | ||
| "then echo 'NO CHRG jumper is set, not waiting';" \ | ||
| "else silabs scaps wait pct ${chrg_pct};" \ | ||
| "fi;" \ | ||
| "fi;\0" \ | ||
| "silo_chrg_pct=60\0" \ |
There was a problem hiding this comment.
I'm not sure what the current paradigm is, but, with these changes is there:
- A way to enable charging without having to set the
silo_chrg_pctand wait for it? - Not have waiting for charge enabled out of the box so the first boot experience isn't the user waiting ~60 s for the platform to actually turn on.
There was a problem hiding this comment.
- No, but a user could turn this on in linux with tsmicroctl. I'm not sure what the real use case is for this.
- The TS-7100 does not have a no charge jumper. During development the user can press ctrl+c to stop charging and boot. I'll add a printf to make this more apparent that the user can do that to boot immediately.
Comment on lines
-60
to
+58
| "chrg_pct=60\0" \ | ||
| "silochargeon=silabs scaps disable;" \ | ||
| "if test $silopresent = '1';" \ | ||
| "then if test $jpnochrg = 'off';" \ | ||
| "then silabs scaps enable;"\ | ||
| "fi;"\ | ||
| "fi;\0" \ | ||
| "silowaitcharge=if test $silopresent = '1';" \ | ||
| "then if test $jpnochrg = 'on';" \ | ||
| "then echo 'NO CHRG jumper is set, not waiting';" \ | ||
| "else silabs scaps wait pct ${chrg_pct};" \ | ||
| "fi;" \ | ||
| "fi;\0" \ | ||
| "silo_chrg_pct=60\0" \ |
There was a problem hiding this comment.
I'm not sure what the current paradigm is, but, with these changes is there:
- A way to enable charging without having to set the
silo_chrg_pctand wait for it? - Not have waiting for charge enabled out of the box so the first boot experience isn't the user waiting ~60 s for the platform to actually turn on.
There was a problem hiding this comment.
- Same as the last, but:
- We do have a no charge jumper on this board. I'll add a preboot in the next pass that sets the charge percent to 0.
This is now controlled completely by 'silo_chrg_pct' on both boards. If the variable doesn't exist, supercaps are disabled If the variable is 0, supercaps charging is enabled and we boot immediately if the variable is 1-100, we enable and wait until the caps are charged to that percent If it is > 100, it is capped to 100
markfeathers
force-pushed
the
ts7100-ts7180-micro
branch
from
51108b7 to
a8478d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to new silo driver. remove older utility, and control the feature only from silo_chrg_pct.
Enable FDT overlay support