Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Move logic out of ember-cli commands #1063

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bertdeblock
Copy link
Member

After this, we can easily:

  1. Migrate everything else (except ./lib/ember-cli-commands) to .mjs
  2. Update all our dependencies to latest because of 1.
  3. Introduce our own CLI to use ember-try without ember-cli

@bertdeblock bertdeblock self-assigned this Jan 29, 2025
@bertdeblock bertdeblock force-pushed the move-logic-out-of-ember-cli-commands branch from 4d77de0 to bda3dce Compare January 29, 2025 10:16
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (e0d196e) to head (bda3dce).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1063      +/-   ##
==========================================
- Coverage   95.54%   95.15%   -0.39%     
==========================================
  Files          21       18       -3     
  Lines         516      475      -41     
==========================================
- Hits          493      452      -41     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mansona
Copy link
Member

mansona commented Jan 29, 2025

what would it look like to invert this? i.e. make this a type=module package with an index.cjs ? I'm only asking because we're changing most files across to mjs and it seems like that is wanting to be type=module 🤔

@bertdeblock
Copy link
Member Author

bertdeblock commented Jan 29, 2025

I was under the assumption that importing cjs from inside a type=module package was not an option. But I assume this might work by configuring package.json#exports? Would be better indeed.

@mansona
Copy link
Member

mansona commented Jan 29, 2025

yes you can configure package.json exports to point at a cjs file for the index 👍

@bertdeblock
Copy link
Member Author

Alright, would be much better indeed. Will update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants