Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close All Toasts Feature #197

Closed
wants to merge 0 commits into from
Closed

Close All Toasts Feature #197

wants to merge 0 commits into from

Conversation

choeqq
Copy link
Contributor

@choeqq choeqq commented Oct 21, 2023

Issues 😢


What has been done 😄

  • Created close all toasts feature - unless there is only one toast, the button will always be displayed on last toast visible
  • animations are little off, each toast should go down one by one (done ✅ )

Screenshots 📸

Screenshot 2023-10-21 at 20 39 58 copy

@vercel
Copy link

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sonner ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 6:35pm

@choeqq choeqq changed the title Close All Toasts Close All Toasts Feature Oct 21, 2023
@lucasspra
Copy link

Could it be possible to change the text of the button, maybe through a prop? My application is not in English

Copy link
Contributor Author

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Just updated Close All Feature, please check out whether you like it or not @lucasspra 😉

@emilkowalski
Copy link
Owner

Hi! Just updated Close All Feature, please check out whether you like it or not @lucasspra 😉

This is great, can we center the text in the button vertically and move the text closeAllButtonText to <Toaster /> instead?

@emilkowalski emilkowalski self-requested a review October 21, 2023 22:16
pnpm-lock.yaml Outdated Show resolved Hide resolved
src/styles.css Outdated Show resolved Hide resolved
Copy link
Contributor Author

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes has been commited, please let me know whether you have any other ideas to make this solution greater 😄

Since all the changes has been applied I allowed myself to resolve your comments, I don't know how it works in this project yet - so please hit me up if that's not the way you all are doing it right here 😄

@emilkowalski 👀

@lucasspra
Copy link

@choeqq That's what I needed, thank you! 🫶

Copy link
Contributor Author

@choeqq choeqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilkowalski could you please take a look? 😄 🚀

@emilkowalski
Copy link
Owner

emilkowalski commented Oct 31, 2023

@choeqq Sorry for the delay, it looks great! Only missing thing is exit animation on the first toast, it just disappears, or was that intented?. If not, could you take a look at it and then we can merge?

CleanShot.2023-10-31.at.03.55.03.mp4

@choeqq
Copy link
Contributor Author

choeqq commented Oct 31, 2023

No problem, everyone of us is busy 😄
The flow is as follows: after clicking close all we're invoking the 'folding' of all toasts just like when hover out of toasts, and then they just dismiss, I think it looks fine, but you're the owner of the project so, please feel free to add any requriements, and I'll adjust my solution to your needs 😄

@emilkowalski
Copy link
Owner

Thanks! The toast at the bottom is just disappearing, could we make this one fadeout to the bottom as well?

@emilkowalski
Copy link
Owner

Also, we should add documentation as well.

@choeqq
Copy link
Contributor Author

choeqq commented Nov 13, 2023

Hi @emilkowalski just added API reference for close all toasts feature, I am having little trouble with animating the fadeout of all toasts, could you please help me little bit with that part? 😄

@andersonbruno
Copy link

Was this removed? I noticed in the last push to main, that it isn't there anymore. Any chance to have this functionality?

@jihea-park
Copy link

@emilkowalski
Was this removed??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants