ci: fix browser-tests ubuntu 24.04 compat #2587
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,7 +9,8 @@ on: | |||||
| jobs: | ||||||
| browser-tests: | ||||||
| timeout-minutes: 30 | ||||||
| runs-on: ubuntu-24.04 | ||||||
| # runs-on: ubuntu-latest | ||||||
| # This Chrome nightly image can no longer install browsers in Github CI for | ||||||
| # lack of some system dependencies: | ||||||
| # Package 'libasound2' has no installation candidate | ||||||
|
|
@@ -23,9 +24,20 @@ jobs: | |||||
| # ## the Selenium image is configured to not run as root, so we have to undo some of it | ||||||
| # env: | ||||||
| # HOME: /root # Firefox complains otherwise | ||||||
| env: | ||||||
| DEBIAN_FRONTEND: noninteractive | ||||||
| steps: | ||||||
| - name: Put unstable chrome where playwright would look for it | ||||||
| run: mv /opt/google/chrome /opt/google/chrome-unstable | ||||||
| - name: Install browser dependencies | ||||||
| run: | | ||||||
| sudo apt-get update | ||||||
| sudo apt-get install -y --no-install-recommends \ | ||||||
| ca-certificates \ | ||||||
| libatomic1 libflite1 libgles2 libharfbuzz-icu0 libhyphen0 libmanette-0.2-0 libicu74 libsecret-1-0 libxslt1.1 woff2 \ | ||||||
| ca-certificates fonts-liberation libatk-bridge2.0-0 libatk1.0-0 libc6 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgbm1 libgcc1 libglib2.0-0 libgtk-3-0 libnspr4 libnss3 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 lsb-release wget xdg-utils \ | ||||||
| libvpx9 libevent-2.1-7t64 libopus0 libgstreamer-plugins-base1.0-0 libgstreamer-gl1.0-0 libgstreamer-plugins-bad1.0-0 gstreamer1.0-libav | ||||||
|
Comment on lines
+32
to
+39
There was a problem hiding this comment. are all of these extra deps required? or can any be left out to be more minimal There was a problem hiding this comment. They may not all be required. Most if not all were previously installed under the hood by the playwright util. There was a problem hiding this comment.
There was a problem hiding this comment. Are you sure changes needed to the action runner? This looks like a Playwright issue that was fixed in 1.45. |
||||||
|
|
||||||
| - uses: actions/checkout@v4 | ||||||
| - uses: actions/setup-node@v3 | ||||||
| with: | ||||||
|
|
@@ -41,10 +53,10 @@ jobs: | |||||
| run: npm ci --ignore-scripts | ||||||
| - name: Install Playwright Browsers | ||||||
| working-directory: browser-test | ||||||
| run: npm exec playwright install --with-deps | ||||||
|
There was a problem hiding this comment. Doesn't There was a problem hiding this comment. atm should be
Suggested change
There was a problem hiding this comment.
yep let's stick with
|
||||||
| - name: Run Playwright tests | ||||||
| working-directory: browser-test | ||||||
| run: npm exec playwright test | ||||||
| - uses: actions/upload-artifact@v3 | ||||||
| if: always() | ||||||
| with: | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,7 @@ | |
| "test": "playwright test" | ||
| }, | ||
| "devDependencies": { | ||
| "@playwright/test": "^1.48.1", | ||
| "@types/node": "^20.11.16" | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't latest 24.04? did
ubuntu-latestcause a problem or are you just wanting to defend against that changing?I think we should stick with
ubuntu-latestbecause that's what Playwright advises with GitHub Actions:https://playwright.dev/docs/ci-intro#setting-up-github-actions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, now, but it was unpredictably (A/B from GH side?) switching back and forth between 22.04 and 24.04 between CI runs for a period around at the time of PR creation, which was causing inconsistent CI results.
Not clear if the next transition of
ubuntu-latestwill be cleaner or similarly messy and require a similar workaround whenever it happens.