Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: playground equipment: lint / test dev tools #6

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Conversation

dckc
Copy link
Contributor

@dckc dckc commented Jan 16, 2024

factored out of #2

question: should packages such as ag-trade have their own yarn.lock? Or should the whole playground share a yarn.lock?

dckc added 5 commits January 9, 2024 23:22
$ ../endo/scripts/create-package.sh ag-trade
$ mv ../endo/packages/ag-trade/ packages/

create-package.sh:
2024-01-08 15:27 4d7aa98c8 fix(scripts): Update create-package comment doc
  - add prettier
  - ignore node_modules
@dckc dckc requested a review from kriskowal January 16, 2024 22:32
@kriskowal
Copy link
Member

I like the idea of separate lockfiles for various experiments.

Copy link
Member

@kriskowal kriskowal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don’t trouble to make this perfect.

I don’t feel strongly about whether this should closely resemble the endo repository, but copying scripts and packages/skel along with all the lint configuration you have here certainly makes a lot easier.

Not afraid of a mess in this repo. Maybe someday some stuff graduates to an analogous @endo/kit repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be deleted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn’t be checked in. maybe need .gitignore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know how it got there at all?

@@ -0,0 +1,67 @@
{
"name": "@endo/skel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the skeleton unaltered

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this is exactly the skeleton, unaltered; i.e. before we start playing

I'm a little surprised that there are any ag-trade/ files here at all, but I suppose the way I did this was to run the skeleton widget and then try to test / lint and add equipment as needed

@dckc dckc merged commit 5bd23d1 into main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants