-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling default failure predicates. #997
Allow disabling default failure predicates. #997
Conversation
Signed-off-by: Dan Rosen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the CI failed, because README needs to be regenerated.
Could you try running this locally and uploading the commit?
tools/update_cli_readme_documentation.sh --mode fix
Additionally we should add both a unit test and an e2e test for the new feature. The unit test should live here and the integration test probably here.
Signed-off-by: Dan Rosen <[email protected]>
Done, thanks!
I've added a unit test. I agree an e2e test would make sense, but I'm having some trouble constructing one, maybe you have some advice... My issue is that I can't find a way to configure NH test server to send error responses, which is necessary to verify that there aren't any failure predicates. Any suggestion? |
Without looking closer - could we achieve the same by pointing Nighthawk to a port the test server isn't listening on? |
Signed-off-by: Dan Rosen <[email protected]>
Signed-off-by: Dan Rosen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, glad this approach worked out. I have two minor requests aiming to make the integration test case more understandable.
Signed-off-by: Dan Rosen <[email protected]>
Signed-off-by: Dan Rosen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for moving the code to the utility library.
Looks like the CI is failing due to formatting of Python files, could you execute ci/do_ci.sh fix_format
and see if that helps?
Signed-off-by: Dan Rosen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mergeconflict !
Works on #826