feat: throw error if Prisma client is already extended with Kysely #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 54 60 +6
Branches 8 9 +1
=========================================
+ Hits 54 60 +6 ☔ View full report in Codecov by Sentry. |
eoin-obrien
force-pushed
the
duplicate-extension-error
branch
from
5dc1d80 to
a7f47c8
Compare
Added a check to throw an error if the Prisma client is already extended with Kysely. This change prevents undefined behavior and ensures that the client is not extended multiple times. Introduced a new test case to validate this behavior. BREAKING CHANGE: This change introduces an error where previously there was none, which may affect existing code that accidentally extended the Prisma client multiple times.
eoin-obrien
force-pushed
the
duplicate-extension-error
branch
from
a7f47c8 to
f826055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check to throw an error if the Prisma client is already extended with Kysely. This change
prevents undefined behavior and ensures that the client is not extended multiple times. Introduced a
new test case to validate this behavior.
BREAKING CHANGE: This change introduces an error where previously there was none, which may affect
existing code that accidentally extended the Prisma client multiple times.