-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): add tooltip for conversation settings icon (Issue #2842) #2877
Merged
Derikyan
merged 11 commits into
development
from
fix/2842-mobile-conversation-header-menu-settings
Dec 26, 2024
Merged
fix(chat): add tooltip for conversation settings icon (Issue #2842) #2877
Derikyan
merged 11 commits into
development
from
fix/2842-mobile-conversation-header-menu-settings
Dec 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to development
…to development
…to development
…to development
…to development
…to development
…to development
Derikyan
requested review from
Gimir,
denys-kolomiitsev,
Alexander-Kezik,
IlyaBondar and
likeamike
as code owners
December 25, 2024 20:17
/deploy-review
|
IlyaBondar
approved these changes
Dec 26, 2024
Derikyan
deleted the
fix/2842-mobile-conversation-header-menu-settings
branch
December 26, 2024 20:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tested on staging env in mobile device: there is proper tooltip on model icon click (ok), but there is no tooltip on conversation setting (need to be implemented)
Issues:
UI changes
Checklist:
fix(<scope>):
,feat(<scope>):
,feature(<scope>):
,chore(<scope>):
,hotfix(<scope>):
ore2e(<scope>):
. If contains breaking changes then the pull request name must start withfix(<scope>)!:
,feat(<scope>)!:
,feature(<scope>)!:
,chore(<scope>)!:
,hotfix(<scope>)!:
ore2e(<scope>)!:
where<scope>
is name of affected project:chat
,chat-e2e
,overlay
,shared
,sandbox-overlay
, etc.(Issue #<TICKET_ID>)
(comma-separated list of issues)