Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): add tooltip for conversation settings icon (Issue #2842) #2877

Merged

Conversation

Derikyan
Copy link
Contributor

@Derikyan Derikyan commented Dec 25, 2024

Description:

Tested on staging env in mobile device: there is proper tooltip on model icon click (ok), but there is no tooltip on conversation setting (need to be implemented)

Снимок экрана 2024-12-26 в 00 16 54

Issues:

UI changes

Снимок экрана 2024-12-26 в 00 17 30

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Derikyan Derikyan added the bug Something isn't working label Dec 25, 2024
@Derikyan Derikyan self-assigned this Dec 25, 2024
@Derikyan
Copy link
Contributor Author

Derikyan commented Dec 25, 2024

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2877.nightly-test.deltixhub.io
E2E tests status: success

@Derikyan Derikyan merged commit 4c608c0 into development Dec 26, 2024
8 checks passed
@Derikyan Derikyan deleted the fix/2842-mobile-conversation-header-menu-settings branch December 26, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants