EPMGCIP-164: Implement Footer #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordoney
requested review from
DmitryLukyanov,
usavkov-epam and
Dzmitry-Yaniuk
gordoney
changed the title
usavkov-epam
approved these changes
Dec 27, 2024
| icon: JSX.Element; | ||
| } | ||
|
|
||
| export default function CircleLink({ link, icon }: Props) { |
There was a problem hiding this comment.
What do you think about using arrow functions (AFs) for React components instead? From my opinion it is more preferable way to declare functional components
| /> | ||
| </div> | ||
| <div className={styles.copyright}> | ||
| ©{currentYear}. All copyrights reserved. Copying website content allowed only on permission |
There was a problem hiding this comment.
- How about using
©HTML meta-symbol to guarantee that browser interprets symbol properly? - Let's, please, put these messages (including contact details) into translation messages so it could translated later easily without affecting source code
| import Footer from './Footer'; | ||
|
|
||
| describe('Footer', () => { | ||
| it('renders correctly and show current year', () => { |
There was a problem hiding this comment.
I suppose it would be also good to validate the following footer elements:
- All social media links
- Copyrights
- Contact details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://jira.epam.com/jira/browse/EPMGCIP-164
Preview
https://676d74de2c3980dfbbcbc4ef--staging-savitsky-museum.netlify.app/en
Code changes
Footercomponent with social networksCircleLinkcomponent for rendering styled linksRecording.2024-12-26.192321.mp4