Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Fix missing modal size auto #4449

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(docs): Fix missing modal size auto #4449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/docs/page-config/ui-elements/confirm/api-description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default defineApiDescription({
message: "Content of modal body",
attachElement: "A valid selector of element, where modal will be rendered",
disableAttachment: "Ignore `attach-element` prop and render component as it's parent child",
size: "Set the size of the modal's width. `\"small\"`, `\"medium\"` (default) or `\"large\"`",
size: "Set the size of the modal's width. `\"auto\"`, `\"small\"`, `\"medium\"` (default) or `\"large\"`",
okText: "Text string to place in the default footer **Ok** button",
cancelText: "Text string to place in the default footer **Cancel** button",
hideDefaultActions: "Use `hide-default-actions: true` to hide **Cancel** and **Ok** buttons",
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/page-config/ui-elements/modal/api-description.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default defineApiDescription({
message: "Content of modal body",
attachElement: "A valid selector of element, where modal will be rendered",
disableAttachment: "Ignore `attach-element` prop and render component as it's parent child",
size: "Set the size of the modal's width. `\"small\"`, `\"medium\"` (default) or `\"large\"`",
size: "Set the size of the modal's width. `\"auto\"`, `\"small\"`, `\"medium\"` (default) or `\"large\"`",
okText: "Text string to place in the default footer **Ok** button",
cancelText: "Text string to place in the default footer **Cancel** button",
hideDefaultActions: "Use `hide-default-actions: true` to hide **Cancel** and **Ok** buttons",
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/page-config/ui-elements/modal/examples/ModalSizing.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="mr-6 my-1"
@click="showModalSizeAuto = !showModalSizeAuto"
>
Show modal size small
Show modal size auto
</VaButton>

<VaButton
Expand Down
2 changes: 1 addition & 1 deletion packages/docs/page-config/ui-elements/modal/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default definePageConfig({
}),
block.example("ModalSizing", {
title: "Modal sizing",
description: "Modals have three optional sizes, available via the prop `size`. These sizes kick in at certain breakpoints to avoid horizontal scrollbars on narrower viewports. Valid optional sizes are `small`, `medium` (default), and `large`."
description: "Modals have three optional sizes, available via the prop `size`. These sizes kick in at certain breakpoints to avoid horizontal scrollbars on narrower viewports. Valid optional sizes are `auto`, `small`, `medium` (default), and `large`."
}),

block.example("NestedModals", {
Expand Down