Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release action support retag and push service image #30

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

chengjoey
Copy link
Member

@chengjoey chengjoey commented Nov 6, 2023

Description

release action support retag and push service image

Checklist

  • I made sure to check the compatibility of the erda version statemented in the action's spec.yml.
  • My change is adequately tested.

# 服务的base镜像
image: registry.erda.cloud/erda-x/openjdk:8_11
# target镜像名称
retagImage: ${{ configs.REGISTRY }}/library:trade-runtime-${{ random.integer }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random.integer is inappropriate. use timestamp.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sfwn
Copy link
Member

sfwn commented Nov 14, 2023

/approve

@erda-bot erda-bot added the approved Approve merging these changes label Nov 14, 2023
@erda-bot erda-bot merged commit 7cd9e5b into erda-project:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approve merging these changes
Development

Successfully merging this pull request may close these issues.

3 participants