feat: release products use retag image registry #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iutx
requested changes
Nov 15, 2023
actions/release/1.0/README.md
Outdated
| @@ -338,4 +338,6 @@ release action 运行成功后会在当前目录生成 `dicehub-release` 文件 | |||
| registryUsername: ${{ secrets.REGISTRY_USERNAME }} | |||
| # 远端镜像仓库的密码 | |||
| registryPassword: ${{ secrets.REGISTRY_PASSWORD }} | |||
| # 制品 不使用retag中镜像地址 | |||
| notRetag: true | |||
There was a problem hiding this comment.
notRetag points to ambiguity, what is needed is the replacement of the image in the dice release, rather than determining whether to execute a retag. @CeerDecy
There was a problem hiding this comment.
have change to releaseImgNotRetag
iutx
reviewed
Nov 15, 2023
| RetagImage string `json:"retagImage"` | ||
| RegistryUsername string `json:"registryUsername"` | ||
| RegistryPassword string `json:"registryPassword"` | ||
| ReleaseImgNotRetag bool `json:"releaseImgNotRetag"` // 是否使用RetagImage对应的镜像仓库,默认false为使用RetagReg的镜像仓库,true为同时上传两个镜像仓库【默认镜像】和【Retag镜像】， |
There was a problem hiding this comment.
change ReleaseImgNotRetag tag name to useRetagImage
iutx
reviewed
Nov 16, 2023
| if cfg.Services != nil { | ||
| insertCommands(&dCopy, cfg) | ||
| // 默认将制品中使用的镜像修改成retag中的镜像 |
There was a problem hiding this comment.
Do not impact the existing functionality; the logic for useRetagImage should not take effect if the user has not provided RetagImage.
There was a problem hiding this comment.
Added RetagImage == "" judgment logic in the useRetagImage function
|
/lgtm @sfwn |
iutx
approved these changes
Nov 20, 2023
|
/approve |
erda-bot
previously approved these changes
Nov 22, 2023
CeerDecy
force-pushed
the
feature/registry-by-retag
branch
from
0684e2b to
8254955
Compare
CeerDecy
force-pushed
the
feature/registry-by-retag
branch
from
6111198 to
8398288
Compare
sfwn
approved these changes
Nov 22, 2023
|
/approve |
erda-bot
approved these changes
Nov 22, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
release products use retag image registry