Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlite3-xorm provider #310

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

Malyue
Copy link
Collaborator

@Malyue Malyue commented Jan 8, 2024

What this PR does / why we need it:

add a sqlite3-xorm provider which implements the mysqlxorm
it can use to write for unit-test instead of mock

Which issue(s) this PR fixes:

Fixes #

Specified Reviewers:

/assign @sfwn

@erda-bot erda-bot requested a review from sfwn January 8, 2024 10:14
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (67b1657) 35.18% compared to head (bf76e06) 35.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   35.18%   35.31%   +0.13%     
==========================================
  Files         106      108       +2     
  Lines        5949     5983      +34     
==========================================
+ Hits         2093     2113      +20     
- Misses       3698     3709      +11     
- Partials      158      161       +3     
Files Coverage Δ
providers/mysqlxorm/xorm.go 27.65% <ø> (ø)
providers/mysqlxorm/sqlite3/interface.go 76.47% <76.47%> (ø)
providers/mysqlxorm/session.go 0.00% <0.00%> (ø)
providers/mysqlxorm/sqlite3/provider.go 41.17% <41.17%> (ø)

... and 1 file with indirect coverage changes

providers/mysqlxorm/sqlite3/examples/main.go Show resolved Hide resolved
providers/mysqlxorm/sqlite3/interface.go Outdated Show resolved Hide resolved
providers/mysqlxorm/sqlite3/provider.go Outdated Show resolved Hide resolved
providers/mysqlxorm/sqlite3/provider.go Outdated Show resolved Hide resolved
providers/mysqlxorm/sqlite3/interface.go Show resolved Hide resolved
providers/mysqlxorm/sqlite3/interface.go Outdated Show resolved Hide resolved
@Malyue Malyue force-pushed the feat/sqlite3-xorm-provider branch from 28b257d to a2b5cfe Compare January 9, 2024 06:05
@sfwn
Copy link
Member

sfwn commented Jan 9, 2024

/approve

@Malyue Malyue force-pushed the feat/sqlite3-xorm-provider branch from a2b5cfe to bf76e06 Compare January 9, 2024 06:24
@erda-bot erda-bot merged commit 7847b1f into erda-project:master Jan 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants