Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix mf_share #4054

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: fix mf_share #4054

merged 1 commit into from
Aug 27, 2024

Conversation

laojun
Copy link
Contributor

@laojun laojun commented Aug 27, 2024

What this PR does / why we need it:

I have checked the following points:

  • I18n is finished and updated by cli
  • Form fields validation is added and length is limited
  • Display normally on small screen
  • Display normally when some data is empty or null
  • Display normally in english mode

Which issue(s) this PR fixes:

Fixes #

  • Fixes #your-issue_number
  • [Erda Cloud Issue Link](paste your link here)

Does this PR introduce a user interface change?

✅ Yes(screenshot is required)
❎ No

ChangeLog

Language Changelog
🇺🇸 English fix: fix mf_share
🇨🇳 中文 fix: fix mf_share

Need cherry-pick to release versions?

✅ Yes(version is required)
❎ No

@erda-bot erda-bot added the bugfix Used in pr label Aug 27, 2024
@laojun laojun merged commit b3f2bbb into erda-project:master Aug 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Used in pr
Development

Successfully merging this pull request may close these issues.

2 participants