Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the looks, especially when embedded in a nav, and add service icons next to names #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rantav
Copy link

@rantav rantav commented Jul 25, 2013

Perform a few fixes to how the login URLs look when multiple logins and in bootstrap's navbar.
Plus, add service icons next to the names where users are already logged in (so they remember which service they used to login

http://cl.ly/image/2d2s3B3F173E
http://cl.ly/image/1h2r2p280K0n
http://cl.ly/image/3u2k361Z2r3J

The strange thing is - when I first started using this component, all the links sort of had the wrong looks. (such as the login link). So I started by fixing those and then continued a bit. Still it seems strange that I didn't get the correct behavior OOTB, so I figure I did something wrong, but never figured out what it was...

I only tested with multiple serivces, not a single service (and not with email-pass, just github/google).

…nd in bootstrap's navbar. And add service icons next to the names where users are already logged in (so they remember which service they used to login
@rantav
Copy link
Author

rantav commented Jul 25, 2013

oh, one small (maybe not so small) caveat with presenting the current user's logged in service (this http://cl.ly/image/1h2r2p280K0n) is that when we publish the users collection we need to publish something in the services.
For example I have: (coffee)

Meteor.publish "users", ->
  Meteor.users.find {},
    fields:
      profile: 1
      'services.google.picture': 1
      'services.github.picture': 1 # This one's prepopulated at Accounts.onCreateUser since github by default does not add the picture (avatar) url

I haven't found another way to check what's the current user's logged in service name other then that. But I'm fairly new with meteor so maybe there's a better way to achieve this without requiring modifications to the app.

rantav added 3 commits July 25, 2013 12:56
Although bootstrap is indeed a dependency, in order to be able to load it from a CDN, I remove it here (so meteor doesn't load it automatically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant