-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(esp_tinyusb): Added tusb_teardown() call while tinyusb_driver_uninstall() #39
Conversation
@tore-espressif , @peter-marcisovsky I posted two questions for both of you, because it seems that we can make it better and we can use it. I need that for enumeration driver testing (but maybe I will eliminate esp_tinyusb component from the chain, but anyway), so feel free to check it out when possible. Meanwhile, I will go and cover the Enum Driver as much as I can. |
d7cb17d
to
c14eebb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some observations from using the test app
Is there a timeline for this feature to be finalized? |
Hi @finger563 , This feature allows the re-configure the driver with these changes: espressif/tinyusb#27 Meanwhile, this feature should be available in the upstream of TinyUSB, if anything it is possible to use it. Sorry for the inconvenience. |
87ddae1
to
85c3227
Compare
ef29b89
to
7bcc554
Compare
da569b5
to
2954367
Compare
f6dc83c
to
fae1686
Compare
a3bed18
to
fd74487
Compare
fd74487
to
5922503
Compare
I have updated the test, changing the logic to checking the result of "lsusb" output to verify device attachment and detachment while install/uninstall. The previous test with teardown + cdc data exchange between host and device moved here: #106 PTAL |
5922503
to
be83b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roma-jam Looks good, thank you for the test!
be83b3f
to
a444bcb
Compare
Applied several fixes from review in here: #106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I could run the test locally on my setup, works fine.
Requirements
tud_deinit()
feature was implemented in upstream, starting with version v0.17.0.Description
tusb_teardown()
call whiletinyusb_driver_uninstall()
Testing
Notes:
Related issues
espressif/tinyusb
PR: feature(usbd): Added tud_teardown() tinyusb#27 (closed, because of synchronizing with upstream v0.17)