Option to keep or not the textual translations #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Just replied in the forum post above about this. I totally agree with it, but longer term I'll be removing them anyway so I'm not sure if it'll be confusing for folks to put the setting in and then just take it out later |
|
Just a note that translations are now working in #1311 So I think once everyone seems ok with that, the next step will be to pull the translations out of |
|
Translations are in - but actually I'll pull this in now, and change the default to false |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As most apps aren't translated, I found odd the mixed language on apps, so I thought it would be useful to have a locale with formatting but no translation. this way the apps language are all in english, but the format for numbers, dates, etc are in my locale.
As forum post: http://forum.espruino.com/conversations/371915/#comment16353541